Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use golang-crossbuild native to ARM64 #4536

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

use golang-crossbuild native to ARM64 #4536

wants to merge 3 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 3, 2025 •
edited
Loading

What is the problem this PR solves?

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

In the CI, we ran https://buildkite.com/elastic/fleet-server-package-mbp/builds/1673

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@v1v v1v changed the title test: golang-crossbuild native to ARM64 use golang-crossbuild native to ARM64 Mar 3, 2025
@v1v v1v self-assigned this Mar 3, 2025
@v1v v1v added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Mar 3, 2025
@v1v v1v marked this pull request as ready for review March 3, 2025 15:45
@v1v v1v requested a review from a team as a code owner March 3, 2025 15:45
@v1v v1v requested review from kaanyalti, michel-laterman and a team March 3, 2025 15:45
v1v
v1v commented Mar 3, 2025
View reviewed changes
Makefile
Comment on lines -315 to +316
$(eval SUFFIX := arm)
$(eval SUFFIX := ${CROSSBUILD_ARM_SUFFIX})
Copy link
Member Author

@v1v v1v Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm suffix points to debian9, that's how it works in the golang-crossbuild, see elastic/golang-crossbuild#446 that explains that currently the default debian image is 9.

@pazone pazone requested a review from mrodm March 3, 2025 15:50
dliappis
dliappis approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@pazone pazone pazone approved these changes

@pchila pchila pchila approved these changes

@kaanyalti kaanyalti Awaiting requested review from kaanyalti kaanyalti is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@mrodm mrodm Awaiting requested review from mrodm

Assignees

@v1v v1v

Labels
backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @dliappis @pazone @pchila